White list miniblocks from execution results MetaHeaderV3#7857
Merged
miiu96 merged 12 commits intoJun 18, 2026
Merged
Conversation
sstanculeanu
previously approved these changes
May 27, 2026
ssd04
previously approved these changes
Jun 2, 2026
…esults-meta-header
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/testnet-fixes #7857 +/- ##
======================================================
- Coverage 77.59% 77.57% -0.02%
======================================================
Files 884 884
Lines 125274 125210 -64
======================================================
- Hits 97206 97136 -70
- Misses 21619 21622 +3
- Partials 6449 6452 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sstanculeanu
previously approved these changes
Jun 8, 2026
ssd04
previously approved these changes
Jun 8, 2026
sstanculeanu
previously approved these changes
Jun 9, 2026
…esults-meta-header # Conflicts: # epochStart/shardchain/trigger_test.go
ssd04
previously approved these changes
Jun 16, 2026
sstanculeanu
previously approved these changes
Jun 16, 2026
…esults-meta-header
AdoAdoAdo
reviewed
Jun 17, 2026
| if err != nil { | ||
| log.Debug("doWhitelistWithShardHeaderIfNeeded: could not get miniblock headers from execution results", "error", err) | ||
| } | ||
| miniBlockHdrs = append(miniBlockHdrs, execMiniBlockHdrs...) |
Contributor
There was a problem hiding this comment.
these should not be appended, these should replace the miniblocks from header.
| if err != nil { | ||
| log.Debug("doWhitelistWithMetaBlockIfNeeded: could not get miniblock headers from execution results", "error", err) | ||
| } | ||
| miniBlockHdrs = append(miniBlockHdrs, execMiniBlockHdrs...) |
Contributor
There was a problem hiding this comment.
these should not be appended, these should replace the miniblocks from header.
…esults-meta-header
…esults-meta-header
sstanculeanu
approved these changes
Jun 17, 2026
ssd04
approved these changes
Jun 18, 2026
danidrasovean
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
doWhitelistWithMetaBlockIfNeedednow also extracts miniblock headers from V3 execution results and whitelists the cross-shard ones.Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?