Update base timestamp#7842
Merged
Merged
Conversation
sstanculeanu
previously approved these changes
May 11, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/testnet-fixes #7842 +/- ##
======================================================
- Coverage 77.59% 77.58% -0.01%
======================================================
Files 884 884
Lines 125249 125259 +10
======================================================
- Hits 97181 97180 -1
- Misses 21618 21628 +10
- Partials 6450 6451 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
miiu96
previously approved these changes
May 27, 2026
AdoAdoAdo
reviewed
Jun 16, 2026
| return | ||
| } | ||
|
|
||
| timestampMs := header.GetTimeStamp() // it will came as milliseconds for header v3 |
| func (bbc *baseBlockChain) setMetricsBeforeHeaderV3(header data.HeaderHandler) { | ||
| bbc.appStatusHandler.SetUInt64Value(common.MetricNonce, header.GetNonce()) | ||
|
|
||
| timestampS := header.GetTimeStamp() // it will came as seconds before header v3 |
AdoAdoAdo
approved these changes
Jun 16, 2026
miiu96
approved these changes
Jun 17, 2026
sstanculeanu
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?