Skip to content

add outgoing txs inclusion check#7841

Merged
ssd04 merged 10 commits into
feat/testnet-fixesfrom
miniblock-inclusion-checks
Jun 18, 2026
Merged

add outgoing txs inclusion check#7841
ssd04 merged 10 commits into
feat/testnet-fixesfrom
miniblock-inclusion-checks

Conversation

@ssd04

@ssd04 ssd04 commented May 7, 2026

Copy link
Copy Markdown
Contributor

Reasoning behind the pull request

  • Shard is stuck check should be included also on v3 paths:
  • added shard is stuck check when adding outgoing txs
  • when setting num pending miniblocks in shard tracker, added handling for setting the propoer field

Testing procedure

  • System testing with induces shard is stuck

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@ssd04 ssd04 self-assigned this May 7, 2026
@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.58%. Comparing base (5adab78) to head (30eb127).
⚠️ Report is 221 commits behind head on feat/testnet-fixes.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feat/testnet-fixes    #7841      +/-   ##
======================================================
+ Coverage               77.53%   77.58%   +0.04%     
======================================================
  Files                     883      884       +1     
  Lines                  124506   125232     +726     
======================================================
+ Hits                    96536    97155     +619     
- Misses                  21558    21624      +66     
- Partials                 6412     6453      +41     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ssd04 ssd04 marked this pull request as ready for review May 29, 2026 11:37
sstanculeanu
sstanculeanu previously approved these changes May 29, 2026
Comment thread process/block/gasConsumption_test.go Outdated
Co-authored-by: Sorin Stanculeanu <34831323+sstanculeanu@users.noreply.github.com>
Comment thread process/block/gasConsumption.go Outdated

@AdoAdoAdo AdoAdoAdo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are missing also the IsShardStuck(Metachain)

@ssd04 ssd04 merged commit 6387f16 into feat/testnet-fixes Jun 18, 2026
8 of 9 checks passed
@ssd04 ssd04 deleted the miniblock-inclusion-checks branch June 18, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants