HIGH-005: remove queue presence heuristic#7704
Merged
sstanculeanu merged 2 commits intoFeb 12, 2026
Merged
Conversation
sstanculeanu
approved these changes
Feb 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a queue presence heuristic from the execution manager's RemoveAtNonceAndHigher method. Previously, the code would check if the requested nonce was still in the blocks queue and skip cleanup if it was. The new implementation always performs cleanup and blockchain state updates regardless of whether blocks are still queued, which ensures consistency in all scenarios.
Changes:
- Simplified
RemoveAtNonceAndHigherlogic to always clean the execution tracker and update blockchain state - Updated and expanded test coverage to verify the new behavior handles all cases correctly (blocks in queue, already popped, and in queue but processed)
- Reorganized imports to follow Go conventions (external dependencies separated from internal)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| process/asyncExecution/executionManager/executionManager.go | Removed queue presence heuristic logic, simplified to always perform tracker cleanup and blockchain updates |
| process/asyncExecution/executionManager/executionManager_test.go | Updated existing tests and added new test case to verify cleanup happens even when blocks are in cache; reorganized imports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ssd04
approved these changes
Feb 12, 2026
6a12295
into
fix-unsigned-nonce-gap-underflow
13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?