Skip to content

HIGH-005: remove queue presence heuristic#7704

Merged
sstanculeanu merged 2 commits into
fix-unsigned-nonce-gap-underflowfrom
remove-queue-heuristic
Feb 12, 2026
Merged

HIGH-005: remove queue presence heuristic#7704
sstanculeanu merged 2 commits into
fix-unsigned-nonce-gap-underflowfrom
remove-queue-heuristic

Conversation

@AdoAdoAdo

Copy link
Copy Markdown
Contributor

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@AdoAdoAdo AdoAdoAdo changed the title remove queue presence heuristic HIGH-005: remove queue presence heuristic Feb 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a queue presence heuristic from the execution manager's RemoveAtNonceAndHigher method. Previously, the code would check if the requested nonce was still in the blocks queue and skip cleanup if it was. The new implementation always performs cleanup and blockchain state updates regardless of whether blocks are still queued, which ensures consistency in all scenarios.

Changes:

  • Simplified RemoveAtNonceAndHigher logic to always clean the execution tracker and update blockchain state
  • Updated and expanded test coverage to verify the new behavior handles all cases correctly (blocks in queue, already popped, and in queue but processed)
  • Reorganized imports to follow Go conventions (external dependencies separated from internal)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
process/asyncExecution/executionManager/executionManager.go Removed queue presence heuristic logic, simplified to always perform tracker cleanup and blockchain updates
process/asyncExecution/executionManager/executionManager_test.go Updated existing tests and added new test case to verify cleanup happens even when blocks are in cache; reorganized imports

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sstanculeanu sstanculeanu merged commit 6a12295 into fix-unsigned-nonce-gap-underflow Feb 12, 2026
13 checks passed
@sstanculeanu sstanculeanu deleted the remove-queue-heuristic branch February 12, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants