fix todo by moving ShouldConsiderSelfKeyInConsensus to common package

[sstanculeanu]

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

• was the PR targeted to the correct branch?
• if this is a larger feature that probably needs more than one PR, is there a feat branch created?
• if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

[Copilot]

Pull request overview

This PR centralizes the redundancy/self-key decision logic by moving ShouldConsiderSelfKeyInConsensus into a new shared common/consensus package, then updates all call sites (AOT selection + SPoS) to use the shared helper.

Changes:

• Introduced common/consensus.ShouldConsiderSelfKeyInConsensus as the single shared implementation.
• Updated SPoS (worker/subround/consensus state + BLS v1/v2 subrounds) and AOT selection to use the shared helper.
• Moved/reshaped tests by removing package-local tests and adding coverage in common/consensus.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
process/aotSelection/aotSelector.go	Uses shared common/consensus helper instead of local method.
process/aotSelection/aotSelector_test.go	Removes AOTSelector-local tests that targeted the moved helper logic.
consensus/spos/worker.go	Switches self-message checks to shared helper.
consensus/spos/subround.go	Switches leader checks to shared helper.
consensus/spos/consensusState.go	Switches self-message filtering to shared helper.
consensus/spos/common.go	Removes the old SPoS-local helper implementation.
consensus/spos/common_test.go	Removes SPoS-local tests for the removed helper.
consensus/spos/bls/v2/subroundSignature.go	Updates to shared helper.
consensus/spos/bls/v2/subroundEndRound.go	Updates to shared helper.
consensus/spos/bls/v2/subroundBlock.go	Updates to shared helper.
consensus/spos/bls/v1/subroundStartRound.go	Updates to shared helper (import naming inconsistency noted).
consensus/spos/bls/v1/subroundSignature.go	Updates to shared helper.
consensus/spos/bls/v1/subroundEndRound.go	Updates to shared helper.
consensus/spos/bls/v1/subroundBlock.go	Updates to shared helper.
common/consensus/common.go	Adds the shared ShouldConsiderSelfKeyInConsensus implementation.
common/consensus/common_test.go	Adds unit tests for the shared helper behavior.

Comments suppressed due to low confidence (1)

consensus/spos/bls/v1/subroundStartRound.go:18

• In this file the new import github.com/multiversx/mx-chain-go/common/consensus is brought in as consensus, while other updated call sites alias it as commonConsensus. Using the default name here is easy to confuse with the existing github.com/multiversx/mx-chain-go/consensus package and makes it harder to import both in the future without a rename. Consider aliasing this import to commonConsensus here as well and updating the two call sites accordingly for consistency with the rest of the PR (e.g. consensus/spos/worker.go, process/aotSelection/aotSelector.go).

	"github.com/multiversx/mx-chain-go/common/consensus"

	"github.com/multiversx/mx-chain-go/common"
	"github.com/multiversx/mx-chain-go/consensus/spos"
	"github.com/multiversx/mx-chain-go/outport"

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.