Signal execution for sync block#7666
Merged
sstanculeanu merged 7 commits intoFeb 5, 2026
Merged
Conversation
sstanculeanu
previously approved these changes
Feb 4, 2026
…into signal-execution-for-syncBlock
ssd04
reviewed
Feb 4, 2026
| } | ||
|
|
||
| // GetSignalProcessCompletionChan returns the channel used to signal the sync loop after execution completes | ||
| func (boot *baseBootstrap) GetSignalProcessCompletionChan() chan uint64 { |
Contributor
There was a problem hiding this comment.
this does not seem to be used, the chan is set here from execution manager, no need to export it from here
Contributor
Author
There was a problem hiding this comment.
yes, removed - it was only used in a test
danidrasovean
previously approved these changes
Feb 4, 2026
ssd04
approved these changes
Feb 5, 2026
AdoAdoAdo
approved these changes
Feb 5, 2026
sstanculeanu
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?