Skip to content

linter fixes#7663

Merged
BeniaminDrasovean merged 2 commits into
feat/supernova-async-execfrom
supernova-linter-fixes
Feb 3, 2026
Merged

linter fixes#7663
BeniaminDrasovean merged 2 commits into
feat/supernova-async-execfrom
supernova-linter-fixes

Conversation

@BeniaminDrasovean

Copy link
Copy Markdown
Contributor

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request contains linter fixes across multiple Go files, addressing various code quality issues identified by static analysis tools.

Changes:

  • Removed unused error variables, imports, and type definitions
  • Consolidated duplicate import aliases for better code consistency
  • Fixed function signatures by removing unused return values
  • Simplified method calls and refactored control flow structures
  • Corrected type conversions to match function return types

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
txcache/errors.go Removed unused error variable errItemAlreadyInCache
storage/latestData/latestDataProvider.go Changed ParseInt to ParseUint to match uint32 return type
state/storagePruningManager/storagePruningManager_test.go Removed duplicate import alias testStorage (consolidate to stateMock)
state/factory/accountsAdapterAPICreator_test.go Removed duplicate import alias stateMock (consolidate to mockState)
state/blockInfoProviders/currentBlockInfo.go Removed duplicate import alias chainData (consolidate to data)
state/accounts/userAccount.go Simplified method calls from a.dataTrieInteractor.DataTrie() to a.DataTrie()
process/sync/shardForkDetector_test.go Removed duplicate import dataRetriever (consolidate to dataRetrieverMock)
process/block/shardinfo_test.go Removed unused struct type shardInfoCreateDataTestArgs
process/block/shardblock_test.go Removed unused error return value from initBasicTestData() function
process/block/metablock_test.go Consolidated import alias from blproc to processBlock
process/block/metablockProposal_test.go Consolidated import alias from retriever to dataRetriever
integrationTests/chainSimulator/vm/egldMultiTransfer/egldMultiTransfer_test.go Added missing error check for GetAccount call
debug/handler/broadcastDebug_test.go Refactored if-else chain to cleaner switch statement

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@BeniaminDrasovean BeniaminDrasovean merged commit 5081baa into feat/supernova-async-exec Feb 3, 2026
8 of 9 checks passed
@BeniaminDrasovean BeniaminDrasovean deleted the supernova-linter-fixes branch February 3, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants