linter fixes#7663
Merged
BeniaminDrasovean merged 2 commits intoFeb 3, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request contains linter fixes across multiple Go files, addressing various code quality issues identified by static analysis tools.
Changes:
- Removed unused error variables, imports, and type definitions
- Consolidated duplicate import aliases for better code consistency
- Fixed function signatures by removing unused return values
- Simplified method calls and refactored control flow structures
- Corrected type conversions to match function return types
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| txcache/errors.go | Removed unused error variable errItemAlreadyInCache |
| storage/latestData/latestDataProvider.go | Changed ParseInt to ParseUint to match uint32 return type |
| state/storagePruningManager/storagePruningManager_test.go | Removed duplicate import alias testStorage (consolidate to stateMock) |
| state/factory/accountsAdapterAPICreator_test.go | Removed duplicate import alias stateMock (consolidate to mockState) |
| state/blockInfoProviders/currentBlockInfo.go | Removed duplicate import alias chainData (consolidate to data) |
| state/accounts/userAccount.go | Simplified method calls from a.dataTrieInteractor.DataTrie() to a.DataTrie() |
| process/sync/shardForkDetector_test.go | Removed duplicate import dataRetriever (consolidate to dataRetrieverMock) |
| process/block/shardinfo_test.go | Removed unused struct type shardInfoCreateDataTestArgs |
| process/block/shardblock_test.go | Removed unused error return value from initBasicTestData() function |
| process/block/metablock_test.go | Consolidated import alias from blproc to processBlock |
| process/block/metablockProposal_test.go | Consolidated import alias from retriever to dataRetriever |
| integrationTests/chainSimulator/vm/egldMultiTransfer/egldMultiTransfer_test.go | Added missing error check for GetAccount call |
| debug/handler/broadcastDebug_test.go | Refactored if-else chain to cleaner switch statement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sstanculeanu
approved these changes
Feb 3, 2026
ssd04
approved these changes
Feb 3, 2026
AdoAdoAdo
approved these changes
Feb 3, 2026
5081baa
into
feat/supernova-async-exec
8 of 9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?