MX-17488 Last executed nonce metrics#7652
Merged
sstanculeanu merged 5 commits intoFeb 5, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a new metric MetricLastExecutedNonce to track the last executed block nonce in the blockchain node. This metric provides visibility into the execution status of blocks, which is distinct from the current block nonce and useful for monitoring purposes.
Changes:
- Added
MetricLastExecutedNonceconstant and integrated it throughout the metrics system - Updated terminal UI to display the last executed nonce alongside current block height
- Comprehensive test coverage for the new metric across all affected components
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| common/constants.go | Added new constant MetricLastExecutedNonce with value "erd_last_executed_nonce" |
| node/metrics/metrics.go | Initialize the new metric with default value |
| node/metrics/metrics_test.go | Added test verification for metric initialization |
| dataRetriever/blockchain/baseBlockchain.go | Set the metric when last executed block header is updated |
| statusHandler/statusMetricsProvider.go | Include the metric in network metrics output |
| statusHandler/statusMetricsProvider_test.go | Updated tests to verify metric is included in status output |
| statusHandler/persister/persistentHandler.go | Initialize metric in persistent storage |
| cmd/termui/presenter/chainInfoGetters.go | Added getter method for the new metric |
| cmd/termui/presenter/chainInfoGetters_test.go | Added test for getter method |
| cmd/termui/view/interface.go | Added method to Presenter interface |
| cmd/termui/view/termuic/termuiRenders/widgetsRender.go | Display last executed nonce in block info UI |
| cmd/termui/view/termuic/termuiRenders/widgetsRender_test.go | Updated test to verify UI displays the metric |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AdoAdoAdo
reviewed
Feb 4, 2026
AdoAdoAdo
approved these changes
Feb 5, 2026
sstanculeanu
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?