Skip to content

MX-17488 Last executed nonce metrics#7652

Merged
sstanculeanu merged 5 commits into
feat/supernova-async-execfrom
last-executed-nonce-metrics
Feb 5, 2026
Merged

MX-17488 Last executed nonce metrics#7652
sstanculeanu merged 5 commits into
feat/supernova-async-execfrom
last-executed-nonce-metrics

Conversation

@mradian1

Copy link
Copy Markdown

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@mradian1 mradian1 self-assigned this Jan 30, 2026
@mradian1 mradian1 changed the base branch from master to feat/supernova-async-exec January 30, 2026 09:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds a new metric MetricLastExecutedNonce to track the last executed block nonce in the blockchain node. This metric provides visibility into the execution status of blocks, which is distinct from the current block nonce and useful for monitoring purposes.

Changes:

  • Added MetricLastExecutedNonce constant and integrated it throughout the metrics system
  • Updated terminal UI to display the last executed nonce alongside current block height
  • Comprehensive test coverage for the new metric across all affected components

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
common/constants.go Added new constant MetricLastExecutedNonce with value "erd_last_executed_nonce"
node/metrics/metrics.go Initialize the new metric with default value
node/metrics/metrics_test.go Added test verification for metric initialization
dataRetriever/blockchain/baseBlockchain.go Set the metric when last executed block header is updated
statusHandler/statusMetricsProvider.go Include the metric in network metrics output
statusHandler/statusMetricsProvider_test.go Updated tests to verify metric is included in status output
statusHandler/persister/persistentHandler.go Initialize metric in persistent storage
cmd/termui/presenter/chainInfoGetters.go Added getter method for the new metric
cmd/termui/presenter/chainInfoGetters_test.go Added test for getter method
cmd/termui/view/interface.go Added method to Presenter interface
cmd/termui/view/termuic/termuiRenders/widgetsRender.go Display last executed nonce in block info UI
cmd/termui/view/termuic/termuiRenders/widgetsRender_test.go Updated test to verify UI displays the metric

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cmd/termui/view/termuic/termuiRenders/widgetsRender.go
@sstanculeanu sstanculeanu merged commit f10a8e8 into feat/supernova-async-exec Feb 5, 2026
8 of 9 checks passed
@sstanculeanu sstanculeanu deleted the last-executed-nonce-metrics branch February 5, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants