Antiflood supernova config by ssd04 · Pull Request #7651 · multiversx/mx-chain-go

ssd04 · 2026-01-29T13:31:45Z

Reasoning behind the pull request

Add separate Antiflood config for supernova with round activation
Integrate in antiflood components

Testing procedure

Standard system test

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

was the PR targeted to the correct branch?
if this is a larger feature that probably needs more than one PR, is there a feat branch created?
if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

ssd04 · 2026-01-29T14:51:31Z

 }

+func (qfp *quotaFloodPreventer) getBbaseMaxNumMessagesPerPeer() uint32 {
+	if qfp.name == antiflood.OutputIdentifier {


there is custom handling here for this case, because some of the variables are not available in this config struct and they are set 0 by default

ssd04 · 2026-01-29T14:52:40Z

+	initialAntifloodConf := antifloodConfigsHandler.GetCurrentConfig()
+
+	// TODO: this config section have to be loaded with new configration from the start
+	cacheConfig := storageFactory.GetCacherFromConfig(initialAntifloodConf.Cache)


we might need to update Cacher component to set limit dynamically by round if we want to change it dynamically

ssd04 · 2026-01-29T14:53:13Z

+    [[Antiflood.ConfigsByRound]]
+        Round = 440


will have to update config variables for supernova

ssd04 · 2026-01-30T10:03:01Z

 	}

-	mainThrottler, err := throttler.NewNumGoRoutinesThrottler(args.NumConcurrentResolvingJobs)
+	currentConfig := args.AntifloodConfigsHandler.GetCurrentConfig()


this config part is not dynamic, it will load only based on the config at boot time
in order to make it dynamic we have to change GoRountinesThrottler from core

ssd04 · 2026-01-30T10:06:33Z

+	"github.com/multiversx/mx-chain-go/config"
+)
+
+func floodPreventerConfigFetcher(confHandler common.AntifloodConfigsHandler, identifier string) config.FloodPreventerConfig {


this is a bit hacky, but it's due to the fact that we have 4 flood preventer components and 3 of them use config.FloodPreventerConfig and one is based on another config. Before it was handled statically in factory, but now we have to set the configuration dynamically, and there was need for some custom handling

ssd04 · 2026-01-30T12:26:52Z

@@ -627,71 +621,151 @@

 [Antiflood]


TODO: move antiflood config to a separate file

codecov · 2026-02-02T16:44:35Z

Codecov Report

❌ Patch coverage is 83.66013% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.57%. Comparing base (c635e8b) to head (7915425).

Files with missing lines	Patch %	Lines
...e/antiflood/floodPreventers/quotaFloodPreventer.go	67.34%	10 Missing and 6 partials ⚠️
common/configs/antifloodConfigs.go	92.30%	4 Missing and 3 partials ⚠️
factory/core/coreComponentsHandler.go	0.00%	6 Missing ⚠️
node/chainSimulator/components/coreComponents.go	50.00%	3 Missing and 1 partial ⚠️
...ottle/antiflood/blackList/p2pBlackListProcessor.go	85.18%	2 Missing and 2 partials ⚠️
...s/throttle/antiflood/factory/p2pOutputAntiflood.go	76.92%	2 Missing and 1 partial ⚠️
...esolverscontainer/metaResolversContainerFactory.go	60.00%	1 Missing and 1 partial ⚠️
...solverscontainer/shardResolversContainerFactory.go	60.00%	1 Missing and 1 partial ⚠️
factory/core/coreComponents.go	71.42%	1 Missing and 1 partial ⚠️
process/throttle/antiflood/factory/common.go	81.81%	2 Missing ⚠️
... and 1 more

Additional details and impacted files

@@                      Coverage Diff                      @@
##           feat/supernova-async-exec    #7651      +/-   ##
=============================================================
- Coverage                      77.59%   77.57%   -0.03%     
=============================================================
  Files                            877      879       +2     
  Lines                         121752   121849      +97     
=============================================================
+ Hits                           94476    94526      +50     
- Misses                         21008    21032      +24     
- Partials                        6268     6291      +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sstanculeanu · 2026-02-03T15:34:46Z

+	antifloodConfigs common.AntifloodConfigsHandler,
+	configFetcher antiflood.FloodPreventerConfigFetcher,


why not extend AntifloodConfigsHandler, to have new method GetCurrentConfigByType?

or, instead of [[Antiflood.ConfigsByRound]] -> [Antiflood.ConfigsByRound.FastReacting] have something like [Antiflood] -> [[Antiflood.FastReactingByRound]]

i wanted to keep the flow as similar as before, not expose those type consts and keep them in that package (at least that's what a thought when i started the refactoring there).
Yes, it might be better to change the config, will analyse more now

changed config and refactored this part

sstanculeanu · 2026-02-03T15:36:31Z

 	}
-	if config.Antiflood.Enabled {
-		return initP2PAntiFloodComponents(ctx, config, statusHandler, currentPid, processConfigsHandler)
+	if antifloodConfigsHandler.IsEnabled() {


missing nil check

sstanculeanu · 2026-02-03T15:37:44Z

+	ctx context.Context,
+	antifloodConfigsHandler common.AntifloodConfigsHandler,
+) (process.P2PAntifloodHandler, error) {
+	if antifloodConfigsHandler.IsEnabled() {


same here, missing nil check

sstanculeanu · 2026-02-04T11:06:16Z

        [Antiflood.ConfigsByRound.PeerMaxOutput]
-            BaseMessagesPerInterval  = 150
-            TotalSizePerInterval     = 2097152 #2MB/s
+            [Antiflood.ConfigsByRound.PeerMaxOutput.PeerMaxInput]


is this needed? 🤔

yes, in order to make it work with GetConfigByType i had to change it to use the same base config struct (until now 3 flood preventers were using FloodPreventerConfig and one was using directly AntifloodLimitsConfig - which is part of FloodPreventerConfig - with the other variables set to 0 in factory)

sstanculeanu · 2026-02-04T11:08:18Z

remove the entire file

miiu96 · 2026-02-05T10:00:42Z

+	ConfigsByRound []AntifloodConfigByRound
+}
+
+type AntifloodConfigByRound struct {


missing comment

ssd04 added 2 commits January 28, 2026 18:14

update config format for antiflood

f32083d

add antiflood configs handler component

9948d33

ssd04 self-assigned this Jan 29, 2026

ssd04 commented Jan 29, 2026

View reviewed changes

ssd04 added 5 commits January 29, 2026 17:42

update test configs

cfa96e1

add unit tests

3347353

update process antiflood tests

bbda820

update default configs + fix tests

6cdaeef

fix unit + integration tests

d4a4bf4

ssd04 commented Jan 30, 2026

View reviewed changes

ssd04 added 3 commits January 30, 2026 13:36

remove unused variables

1e69ee0

fix factory tests

f4bd7e4

update config + added toml config test for antiflood

2e7f68c

ssd04 commented Jan 30, 2026

View reviewed changes

Merge branch 'feat/supernova-async-exec' into antiflood-supernova-config

c120b05

ssd04 marked this pull request as ready for review January 30, 2026 13:51

Merge branch 'feat/supernova-async-exec' into antiflood-supernova-config

7915425

sstanculeanu reviewed Feb 3, 2026

View reviewed changes

ssd04 added 4 commits February 4, 2026 11:03

updated config to match all flood preventers

18fa2b5

add missing nil checks

4224491

fix status handler tests

1d9137e

Merge branch 'feat/supernova-async-exec' into antiflood-supernova-config

b33a253

sstanculeanu reviewed Feb 4, 2026

View reviewed changes

remove unused file

1edf61c

sstanculeanu previously approved these changes Feb 5, 2026

View reviewed changes

miiu96 reviewed Feb 5, 2026

View reviewed changes

add missing comment

6c19052

ssd04 dismissed sstanculeanu’s stale review via 6c19052 February 5, 2026 11:03

miiu96 previously approved these changes Feb 5, 2026

View reviewed changes

Merge branch 'feat/supernova-async-exec' into antiflood-supernova-config

8c3c702

sstanculeanu previously approved these changes Feb 5, 2026

View reviewed changes

sstanculeanu and others added 3 commits February 5, 2026 14:07

Merge branch 'feat/supernova-async-exec' into antiflood-supernova-config

0454d44

Merge branch 'feat/supernova-async-exec' into antiflood-supernova-config

652ccda

fix peer max output config

fcefb4e

ssd04 dismissed stale reviews from sstanculeanu and miiu96 via fcefb4e February 5, 2026 13:29

sstanculeanu approved these changes Feb 5, 2026

View reviewed changes

miiu96 approved these changes Feb 6, 2026

View reviewed changes

ssd04 merged commit 354c04e into feat/supernova-async-exec Feb 6, 2026
8 of 9 checks passed

ssd04 deleted the antiflood-supernova-config branch February 6, 2026 12:21

		antifloodConfigs common.AntifloodConfigsHandler,
		configFetcher antiflood.FloodPreventerConfigFetcher,

Conversation

ssd04 commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reasoning behind the pull request

Testing procedure

Pre-requisites

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Feb 2, 2026

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ssd04 Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ssd04 commented Jan 29, 2026 •

edited

Loading

ssd04 Feb 4, 2026 •

edited

Loading