Skip to content

chain simulator create block time and bypass flags#7650

Merged
sstanculeanu merged 2 commits into
feat/supernova-async-execfrom
chainsim-create-block-time
Feb 2, 2026
Merged

chain simulator create block time and bypass flags#7650
sstanculeanu merged 2 commits into
feat/supernova-async-execfrom
chainsim-create-block-time

Conversation

@axenteoctavian

@axenteoctavian axenteoctavian commented Jan 29, 2026

Copy link
Copy Markdown
Contributor

Reasoning behind the pull request

  • Need a create block duration argument to test mempool selection

Proposed changes

  • CreateBlockMaxTimePercent percent of the total round duration, default 25%
  • BypassCreateBlockTimeCheck bypass this check, default true

Testing procedure

image - -

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@axenteoctavian axenteoctavian self-assigned this Jan 29, 2026
@codecov

codecov Bot commented Feb 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.62%. Comparing base (b092494) to head (a0b9ce3).
⚠️ Report is 37 commits behind head on feat/supernova-async-exec.

Files with missing lines Patch % Lines
node/chainSimulator/process/processor.go 58.82% 7 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           feat/supernova-async-exec    #7650      +/-   ##
=============================================================
- Coverage                      77.64%   77.62%   -0.03%     
=============================================================
  Files                            877      877              
  Lines                         121667   121763      +96     
=============================================================
+ Hits                           94469    94516      +47     
- Misses                         20939    20986      +47     
- Partials                        6259     6261       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sstanculeanu sstanculeanu merged commit 8c69291 into feat/supernova-async-exec Feb 2, 2026
9 of 11 checks passed
@sstanculeanu sstanculeanu deleted the chainsim-create-block-time branch February 2, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants