implemented direct sent transactions cache

[sstanculeanu]

Reasoning behind the pull request

• some transactions might come from direct send, which means they will not be available on all nodes

Proposed changes

• store the transactions received via direct send in a new cache
• when proposing a header, if there are some porposed transactions received via direct send, broadcast them on the network

Testing procedure

• with feat branch + specific binary to allow direct send

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

• was the PR targeted to the correct branch?
• if this is a larger feature that probably needs more than one PR, is there a feat branch created?
• if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

[codecov]

Codecov Report

❌ Patch coverage is 75.00000% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.52%. Comparing base (0eb2bcc) to head (2e31d75).
⚠️ Report is 21 commits behind head on feat/supernova-async-exec.

Files with missing lines	Patch %	Lines
process/coordinator/process.go	62.50%	14 Missing and 1 partial ⚠️
update/factory/fullSyncInterceptors.go	0.00%	9 Missing ⚠️
consensus/spos/bls/v2/subroundBlock.go	63.15%	4 Missing and 3 partials ⚠️

Additional details and impacted files

@@                      Coverage Diff                      @@
##           feat/supernova-async-exec    #7527      +/-   ##
=============================================================
+ Coverage                      77.51%   77.52%   +0.01%     
=============================================================
  Files                            878      878              
  Lines                         122096   122173      +77     
=============================================================
+ Hits                           94639    94718      +79     
+ Misses                         21152    21142      -10     
- Partials                        6305     6313       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sasurobert]

do we need this kind of feature ? The answer is probably yes, as this open up possibilities of private pools, and different mechanics for that.

I wonder whether there is a moment, earlier than this, in which the broadcasting can happen.

[sstanculeanu]

yes, this should cover the private pools scenario

we decided to broadcast these transactions on the leader, with the proposed header.. not sure when can be done earlier

[sasurobert]

can't you find some better method on doing this. Like having broadcast method pushed on interceptor.save does not look good.

Also, we have peerOriginator which is used only for printing out the trace.

[sstanculeanu]

on this interceptor, yes, peerOriginator is only for print.. but it is useful for heartbeat related messages

indeed, having the broadcast method on Save seems odd, but only on Save we know that the intercepted data is valid

[Copilot]

Pull request overview

This pull request implements a caching mechanism for transactions received via direct send. The feature addresses the issue where direct-sent transactions might not be available on all nodes, by storing them in a dedicated cache and broadcasting them when proposing a block header.

Changes:

• Adds a new DirectSentTransactions cache to the data pool infrastructure
• Implements logic to identify and cache direct-sent intra-shard transactions in TxInterceptorProcessor
• Adds functionality to broadcast cached direct-sent transactions during block proposal (v3 headers only)
• Updates all relevant interfaces, mocks, stubs, and tests

Reviewed changes

Copilot reviewed 60 out of 60 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
process/interceptors/processor/txInterceptorProcessor.go	Core logic to cache direct-sent transactions and remove them when received via broadcast
process/coordinator/process.go	Implements ProposedDirectSentTransactionsToBroadcast to gather and marshal direct-sent transactions for broadcasting
consensus/spos/bls/v2/subroundBlock.go	Integrates direct-sent transaction broadcasting into the consensus block proposal flow
dataRetriever/dataPool/dataPool.go	Adds DirectSentTransactions cache to the data pool
process/block/baseProcess.go	Adds validation for direct-sent cache and proxies coordinator method
config/config.go	Adds configuration structure for direct-sent transactions cache
cmd/node/config/config.toml	Adds default configuration values (30s span and expiry)
Various mock/stub files	Updates to implement new interface methods across test infrastructure

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.