Conversation
This should be considered carefully. We may want to modify the API to support it.
gpestana
reviewed
Jul 20, 2018
|
|
||
| // Code is the protocol's multicodec (a normal, non-varint number). | ||
| // | ||
| // -1 is reserved for the special "unknown" protocol. |
There was a problem hiding this comment.
This comment seems to be inconsistent with the rest of the code. e.g.:
ps = append(ps, Protocol{
Name: "unknown",
Size: -1,
Code: 0,
})
IMO, -1 for unknown protocol fells better.
Member
Author
There was a problem hiding this comment.
Sorry, I changed my mind multiple times half-way through. I agree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be considered carefully. We may want to modify the API to support it.
implements multiformats/multiaddr#70