dep: add "codependencies" for handling version conflicts#132
Merged
aschmahmann merged 2 commits intomasterfrom Aug 25, 2020
Merged
dep: add "codependencies" for handling version conflicts#132aschmahmann merged 2 commits intomasterfrom
aschmahmann merged 2 commits intomasterfrom
Conversation
This patch adds a special, internal, "codependencies" package that allows us to specify minimum required versions for modules we don't directly depend on. Downside: * Anyone using this module will also have to download these deprecated modules. Upside: * After upgrading this module, all "codependencies" will automatically be upgraded to compatible versions. * If unused, codependencies will _not_ end up bloating the binary size. This is because "usage" is computed at the import/package layer, while module version requirements are computed at the module layer.
Member
Author
|
Notes:
|
raulk
reviewed
Aug 25, 2020
Member
Author
|
Filter has moved here as well.
|
Note that we're using codependencies to depend on packages that have been merged in to this package. Co-authored-by: Adin Schmahmann <adin.schmahmann@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds a special, internal, "codependencies" package that allows us to specify minimum required versions for modules we don't directly depend on.
Problem: Updating go-multiaddr without updating go-multiaddr-net and/or go-maddr-filter can cause conflicting type issues.
Proposal: Add "dependencies" on these modules (circular module dependencies are perfectly legal), but avoid actually importing any packages.
Downside:
Upside: