Fixed URL address text padding when urlbar is in focus but not open.#325
Open
HomemadeToast57 wants to merge 1 commit intomuckSponge:masterfrom
Open
Fixed URL address text padding when urlbar is in focus but not open.#325HomemadeToast57 wants to merge 1 commit intomuckSponge:masterfrom
HomemadeToast57 wants to merge 1 commit intomuckSponge:masterfrom
Conversation
Author
|
(Connecting this PR to original issue) |
M0kh
added a commit
to M0kh/MaterialFox-Updated
that referenced
this pull request
Aug 12, 2022
Added "Fixed URL address text padding when urlbar is in focus but not open" from muckSponge#325
kurbaniec
added a commit
to kurbaniec/Kacper-s-MaterialFox-Plus
that referenced
this pull request
Dec 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the bug
The vertical padding (specifically top padding) of the URL address text is incorrect within its container when you open or switch to a new tab and have focus on the search bar.
To Reproduce
Steps to reproduce the behavior:
chromefolder anduser.jsto profile root directoryScreenshot BEFORE fix

Look at the URL text inside the address bar...
System info
How I fixed it
On line
#208inchrome/urlbar/urlbar.css, I separated the horizontal and vertical padding values for the URL address text within the address bar. I noticed that it was setting ALL padding (every direction) to 0 but the desired styling was 0 padding for the horizontal directions (left and right) and automatic (evenly spaced) padding for the vertical directions (top and bottom). Below is the line of code I changed:Screenshot AFTER fix

Look at the URL text inside the address bar...
Hope this helps!