Draft
Conversation
Owner
Contributor
Author
|
Well, at first I forgot which panels this actually applies to and after a few tries found out it is also the autocomplete, downloads and library panel. Either way, the point of this PR was to remove that 300 lines of code which was specifically made for the pre-70 info panel that had those huge icons and 3 sections. I do agree that things should be separated to files where possible, especially the autocompete and "global" popup styles. What I don't like is the buttons you use on the popups, why not use the full-width iconized ones like Chrome now? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The new popups look very Chrome-ish, so the majority of the styles are no longer needed in my opinion. The separator lines and "Permissions" heading are also no longer needed as there are only two sections now. I removed the connection security icon as it didn't match the address bar one and doesn't exist in Chrome's page popup.
However, this is a draft pull request as there is still some work to be done: