Rename to codeowners, extend configuration capabilities, add pre-commit-hook support#199
Open
robertbublik wants to merge 7 commits intomszostok:mainfrom
Open
Rename to codeowners, extend configuration capabilities, add pre-commit-hook support#199robertbublik wants to merge 7 commits intomszostok:mainfrom
robertbublik wants to merge 7 commits intomszostok:mainfrom
Conversation
Author
|
I tried to rebase and I ran into a lot of conflicts. I can fix them but first I wanted to ask, if you'd prefer to make this PR perhaps a little smaller? I can drop the renaming to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes a few issues at once which I found while getting to know the project. In order to allow the use of
codeowners-validatoras pre-commit hook a lot of changes were necessary. As described in #140 pre-commit hooks do not really work with env variables and flags are currently not supported by the code base. Additionally in #116 it was considered to renamecodeowners-validatortocodeownersin order to make the project more future proof for further functions.Changes proposed in this pull request:
codeowners-validatortocodeownersand create avalidatesubcommand which inhibits the current capabilities of this projectCODEOWNERS_.apiandconfiginto own packagesRelated issue(s)
Additional information
I fixed most of the integration tests but can't run the ones which require an API key. The other tests run fine.
One issue I wasn't able to fix is in the commit c372b63. I have no idea how to add a custom type as flag since I need to convert it somewhere. I would appreciate help there :) Other than that it's very possible I made some errors or mistakes which could be solved more elegantly. Feedback is very welcome!
This PR also includes #197.