patch (iac): [secure-hybrid-network] batch code quality fixes#264
Open
ferantivero wants to merge 6 commits into
Open
patch (iac): [secure-hybrid-network] batch code quality fixes#264ferantivero wants to merge 6 commits into
ferantivero wants to merge 6 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The VPN connection shared key was hardcoded as '123secret' in both local gateway templates. Now passed as a @secure() parameter from the main deployment template. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace the deprecated /providers/ segment pattern with the proper scope property for the spoke NSG diagnostic settings resource. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use azureFirewallResource.properties.ipConfigurations[0] instead of the legacy reference(id, apiVersion) pattern for route next-hop IP. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Disable default outbound internet access on the Bastion subnets in both azure-network and mock-onprem templates, consistent with other subnets in this deployment. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fix incorrect 'Azure SQL instance' descriptions (these are VMs), add new sharedKey parameter, fix descriptions and defaults to match current template state. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A handful of code quality improvements to align the template with current Bicep best practices and address a hardcoded shared key.
What
Test