Open
Conversation
I ran across this code when I was trying to remember now to use the mspass_func_wrapper and noticed: 1. I does not have docstring 2. It is not correct as previous version of this had a bug in how it set the start of time window. You can see the one line change I made. It may break the tests. I actually think this function is not needed. To my mind it would be harder to remember a function with a similar but different name than to just remember what a TimeWindow object is or use a start and end time explicitly set as two parameters.
Collaborator
Author
|
Yup, tests broken as I expected. I thought the tests were checking for the wrong answer that the previous code was returning. I think the correct fix is to just remove that entire function and the tests that reference it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran across this code when I was trying to remember now to use the mspass_func_wrapper and noticed:
I actually think this function is not needed. To my mind it would be harder to remember a function with a similar but different name than to just remember what a TimeWindow object is or use a start and end time explicitly set as two parameters.