if node version >= v7 use normalizeArgs instead of normalizeConnectArgs#25
Open
rdbell wants to merge 1 commit intomscdex:masterfrom
Open
if node version >= v7 use normalizeArgs instead of normalizeConnectArgs#25rdbell wants to merge 1 commit intomscdex:masterfrom
rdbell wants to merge 1 commit intomscdex:masterfrom
Conversation
sacerro
approved these changes
Mar 7, 2019
|
Curious why this hasn't been merged? Seems to be a very common issue given that this impact core functionality of the module. I am now forced to fork and cherry-pick this fix so that I can point to a stable location while I wait for this fix to be merged. |
|
I'm sorry, it seems this project is abandoned... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #22