copy normalizeConnectArgs from node 6#23
Open
lee-elenbaas wants to merge 3 commits intomscdex:masterfrom
Open
Conversation
Author
|
net._normalizeConnectArgs is not longer available on node 7 - so i removed the dependency in it, by placing the implementation inside the library |
|
@mscdex do you have time to review this PR? This is likely true as we have a few users reporting similar issues. |
|
👍 , I am also having this issue. |
|
Same here - breaks on node >7. The fix looks good! |
Author
gravityrail
approved these changes
Nov 15, 2017
gravityrail
left a comment
gravityrail
left a comment
There was a problem hiding this comment.
I need this! This module doesn't work in Node 8 otherwise.
|
Ping @mscdex - could you please merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #22