perf: TipInstability()#37
Merged
Merged
Conversation
The previous commit shipped src/tip_instability.cpp and registered TIP_INSTABILITY in Rogue_init.c, but Makevars still listed only the C objects, so the new C++ object was compiled but never put on the link line. On macOS (-undefined dynamic_lookup) the .so links cleanly with the symbol unresolved, then dlopen fails at load: symbol not found in flat namespace '_TIP_INSTABILITY' Add tip_instability.o to OBJECTS and set CXX_STD = CXX17 (matches DESCRIPTION SystemRequirements). Local Windows builds passed only because they used the working-tree Makevars. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The previous commit shipped src/tip_instability.cpp and registered TIP_INSTABILITY in Rogue_init.c, but Makevars still listed only the C objects, so the new C++ object was compiled but never put on the link line. On macOS (-undefined dynamic_lookup) the .so links cleanly with the symbol unresolved, then dlopen fails at load: symbol not found in flat namespace '_TIP_INSTABILITY' Add tip_instability.o to OBJECTS and set CXX_STD = CXX17 (matches DESCRIPTION SystemRequirements). Local Windows builds passed only because they used the working-tree Makevars. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
… tip-instab-in-c
Rinternals.h defines `#define length(x) Rf_length(x)` globally. When <vector> is included after <Rinternals.h>, that macro fires inside libc++'s __locale:792 (`length` method), producing errors: too many arguments provided to function-like macro invocation '__abi_tag__' attribute only applies to structs/variables/... Fix: include all C++ standard headers before any R headers. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.