test: Add failing tests for clearing optional view props (#1184)#1433
Draft
mfazekas wants to merge 2 commits into
Draft
test: Add failing tests for clearing optional view props (#1184)#1433mfazekas wants to merge 2 commits into
mfazekas wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
6 tasks
mfazekas
force-pushed
the
test/view-optional-prop-null-repro
branch
from
6bf13b8 to
0641d4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro-only PR for #1184 (companion to the fix in #1432): setting an optional view prop and then clearing it (removing it, or setting it to
undefined) crashes React's commit. The new harness tests fail in CI on this PR - that's the point.Adds
optionalString/nullableString/optionalCallbackto the existingTestViewspec and on-device harness tests that set and then clear each of them. 4 of the 7 tests fail onmain; with #1432 all 7 pass.The tests live in
example/__tests__/views.harness.tsxrather thangetTests.tsbecause the bug is only reachable by rendering a view and re-rendering it with the prop removed - it needs React's commit path. The Harness workflows pick the file up on both platforms.Checklist
main, narrow scope.bun specsrun, generated files committed.bun lint-allpasses locally.