Show components only from enabled modules.#108
Open
andreiperciun wants to merge 1 commit intomrjmd:8.x-1.xfrom
Open
Show components only from enabled modules.#108andreiperciun wants to merge 1 commit intomrjmd:8.x-1.xfrom
andreiperciun wants to merge 1 commit intomrjmd:8.x-1.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Out of the box the module shows components from disabled modules which clutters blocks listing page and confuses the user.
ComponentDiscovery.phpwas modified to verify if component's module is enabled.Since component doesn't contain module info, verification is done based on component and module paths.