ci(release): drop stale Trystero patch guard from frontend bundle verify#213
Merged
Conversation
The "Verify frontend bundle" step grepped the Vite output for a `trystero-patch` marker to confirm patches/@trystero-p2p__core@0.24.0 was applied. That patch — and the @trystero-p2p/core dependency it patched — were removed when the connection engine moved into the myownmesh daemon (#203), so the marker can never appear in the bundle and the guard fails every release on all five platforms. Remove the obsolete guard. The remaining checks (dist/index.html present, entry rewritten, non-empty assets, no Svelte SSR-runtime leak) are still valid and stay. https://claude.ai/code/session_017UZ6AKBqV2ae2E6XbyoAgq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every
Releaserun fails on all five platforms at the Verify frontend bundle step (e.g. run 26645134375):Root cause
That step (
.github/workflows/release.yml) had a hardcoded guard that grepped the built JS for atrystero-patchmarker, to confirmpatches/@trystero-p2p__core@0.24.0.patchwas applied to the bundled Trystero connection engine.The connection engine moved into the
myownmeshdaemon in #203, which removed the@trystero-p2p/coredependency and its patch from the frontend. There is no longer anypatches/directory,patchedDependenciesentry, or Trystero import (only a user-facing docs link remains). So thetrystero-patchmarker can never appear in the bundle and the guard fails unconditionally — it's dead code from before the migration. The pnpm advice in the error message no longer applies (there's no patch to apply).This is unrelated to the recent mesh v0.1.3 bump (#211): that change is Rust-only, and the release fails at the frontend step before the Rust/Tauri build even runs.
Fix
Remove the obsolete Trystero-patch guard. The remaining checks in the step stay and are still valid:
dist/index.htmlexists,/src/main.ts),dist/assetsis non-empty,lifecycle_function_unavailable).YAML validated locally (
yaml.safe_load). After merge, re-running the release should get past frontend verification and proceed to the Tauri build (which picks up myownmesh v0.1.3).https://claude.ai/code/session_017UZ6AKBqV2ae2E6XbyoAgq
Generated by Claude Code