Attempt to improve explain English prompt

.github/workflows/eval-functions.yml

@@ -104,12 +104,12 @@ jobs:
           mkdir -p eval-results
           EVAL_ERRORS=0
 
-          echo "Running explainText evaluation..."
-          genkit eval:flow explainText \
-            --input datasets/explain-chinese.json \
-            --evaluators=custom/chineseTextPresent,custom/validPinyinFormat,custom/outputStructureValid,custom/grammarExplanationQuality \
-            --batchSize 10 \
-            --output eval-results/explain-chinese-results.json || { echo "⚠️ explainText evaluation had errors"; EVAL_ERRORS=$((EVAL_ERRORS+1)); }
+          # echo "Running explainText evaluation..."
+          # genkit eval:flow explainText \
+          #   --input datasets/explain-chinese.json \
+          #   --evaluators=custom/chineseTextPresent,custom/validPinyinFormat,custom/outputStructureValid,custom/grammarExplanationQuality \
+          #   --batchSize 10 \
+          #   --output eval-results/explain-chinese-results.json || { echo "⚠️ explainText evaluation had errors"; EVAL_ERRORS=$((EVAL_ERRORS+1)); }
 
           echo "Running explainEnglish evaluation..."
           genkit eval:flow explainEnglish \
@@ -118,26 +118,26 @@ jobs:
             --batchSize 10 \
             --output eval-results/explain-english-results.json || { echo "⚠️ explainEnglish evaluation had errors"; EVAL_ERRORS=$((EVAL_ERRORS+1)); }
 
-          echo "Running generateChineseSentences evaluation..."
-          genkit eval:flow generateChineseSentences \
-            --input datasets/generate-chinese-sentences.json \
-            --evaluators=custom/chineseTextPresent,custom/validPinyinFormat,custom/outputStructureValid,custom/sentenceGenerationQuality \
-            --batchSize 10 \
-            --output eval-results/generate-sentences-results.json || { echo "⚠️ generateChineseSentences evaluation had errors"; EVAL_ERRORS=$((EVAL_ERRORS+1)); }
-
-          echo "Running analyzeCollocation evaluation..."
-          genkit eval:flow analyzeCollocation \
-            --input datasets/analyze-collocation.json \
-            --evaluators=custom/chineseTextPresent,custom/englishTranslationPresent,custom/outputStructureValid \
-            --batchSize 10 \
-            --output eval-results/collocation-results.json || { echo "⚠️ analyzeCollocation evaluation had errors"; EVAL_ERRORS=$((EVAL_ERRORS+1)); }
-
-          echo "Running explainWordInContext evaluation..."
-          genkit eval:flow explainWordInContext \
-            --input datasets/explain-word-in-context.json \
-            --evaluators=custom/chineseTextPresent,custom/englishTranslationPresent,custom/outputStructureValid \
-            --batchSize 10 \
-            --output eval-results/word-context-results.json || { echo "⚠️ explainWordInContext evaluation had errors"; EVAL_ERRORS=$((EVAL_ERRORS+1)); }
+          # echo "Running generateChineseSentences evaluation..."
+          # genkit eval:flow generateChineseSentences \
+          #   --input datasets/generate-chinese-sentences.json \
+          #   --evaluators=custom/chineseTextPresent,custom/validPinyinFormat,custom/outputStructureValid,custom/sentenceGenerationQuality \
+          #   --batchSize 10 \
+          #   --output eval-results/generate-sentences-results.json || { echo "⚠️ generateChineseSentences evaluation had errors"; EVAL_ERRORS=$((EVAL_ERRORS+1)); }
+
+          # echo "Running analyzeCollocation evaluation..."
+          # genkit eval:flow analyzeCollocation \
+          #   --input datasets/analyze-collocation.json \
+          #   --evaluators=custom/chineseTextPresent,custom/englishTranslationPresent,custom/outputStructureValid \
+          #   --batchSize 10 \
+          #   --output eval-results/collocation-results.json || { echo "⚠️ analyzeCollocation evaluation had errors"; EVAL_ERRORS=$((EVAL_ERRORS+1)); }
+
+          # echo "Running explainWordInContext evaluation..."
+          # genkit eval:flow explainWordInContext \
+          #   --input datasets/explain-word-in-context.json \
+          #   --evaluators=custom/chineseTextPresent,custom/englishTranslationPresent,custom/outputStructureValid \
+          #   --batchSize 10 \
+          #   --output eval-results/word-context-results.json || { echo "⚠️ explainWordInContext evaluation had errors"; EVAL_ERRORS=$((EVAL_ERRORS+1)); }
 
           if [ $EVAL_ERRORS -gt 0 ]; then
             echo "⚠️ $EVAL_ERRORS evaluation(s) had errors - check results for details"

functions/prompts/explain-english.prompt

@@ -7,7 +7,13 @@ output:
   schema: EnglishExplanationSchema
 ---
 {{role "system"}}
-You are a helpful Chinese teacher for speakers of English who want to learn Chinese. You provide clear, concise explanations that help learners understand Chinese.
+You are a helpful Chinese teacher for speakers of English who want to learn Chinese.
+Prioritize accuracy over comprehensiveness — only explain what you are confident about.
+Keep your explanations focused and practical for a language learner.
+
+CRITICAL: Your pinyin, vocabulary breakdown, and grammar explanations must exactly match the Chinese characters in your translation.
+Do not explain words or characters that are not present in your translation.
+
 {{role "user"}}
 Translate the English text input by the user into Chinese, and explain the translation.