Don't allow I_P to go negative due to rounding error#417
Open
richfitz wants to merge 8 commits into
Open
Conversation
We were seeing errors in `n_S_progress` eventually traced back to the calculation of new_I_P. There's a rounding error corner case where a - (b + c) can be slightly negative where a == d and d = b + c
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #417 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 3157 3142 -15
=========================================
- Hits 3157 3142 -15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were seeing errors in
n_S_progresseventually traced back to thecalculation of new_I_P. There's a rounding error corner case where
a - (b + c) can be slightly negative where a == d and d = b + c