Conversation
| } | ||
| }); | ||
| } | ||
| // TODO: Else ensure expected campaign is associated with download |
There was a problem hiding this comment.
URLs like http://localhost:8000/en-US/smart-window/?utm_campaign=smart_window will automatically apply the UTM values to stub attribution parameters, but we probably can't rely on the URL 100% of the time
|
TODO:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1151 +/- ##
==========================================
- Coverage 77.81% 77.77% -0.05%
==========================================
Files 131 131
Lines 8091 8103 +12
==========================================
+ Hits 6296 6302 +6
- Misses 1795 1801 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fcb45e5 to
7cfecdc
Compare
|
|
||
| ### URL: https://www-dev.springfield.moz.works/smart-window/ | ||
|
|
||
| # TODO Smart Window as brand variable? Include comment? |
There was a problem hiding this comment.
Keep forgetting if I can do this, I don't think so.
These files should be handled through Smartling. We cannot configure a subset of locales for special cases, all the vendor locales always go to Smartling
edit: as discussed here: #818 (comment)
|
closing in favour of CMS version: #1247 |
One-line summary
Significant changes and points to review
Issue / Bugzilla link
https://mozilla-hub.atlassian.net/browse/WT-513
Testing
http://localhost:8000/en-US/smart-window/?utm_campaign=smart_window
http://localhost:8000/de/smart-window/?geo=TR
ℹ️ For local or demo UITour use
To develop or test using Mozilla.UITour locally you need to create some custom preferences in about:config.