Skip to content

WIP landing#1151

Closed
maureenlholland wants to merge 1 commit intomainfrom
wt-513--landing-page
Closed

WIP landing#1151
maureenlholland wants to merge 1 commit intomainfrom
wt-513--landing-page

Conversation

@maureenlholland
Copy link
Copy Markdown
Collaborator

@maureenlholland maureenlholland commented Mar 16, 2026

One-line summary

Significant changes and points to review

Issue / Bugzilla link

https://mozilla-hub.atlassian.net/browse/WT-513

Testing

http://localhost:8000/en-US/smart-window/?utm_campaign=smart_window

  • Fx goes to Fx accounts with entrypoint and service set to smartwindow
  • not Fx has download with stub attribution cookie that decodes to include smart_window campaign (i.e. source=(not set)&medium=(direct)&campaign=smart_window&content=(not set)&experiment=(not set)&variation=(not set)&ua=(not set)&client_id_ga4=(not set)&session_id=2443984874&dlsource=fxdotcom)

http://localhost:8000/de/smart-window/?geo=TR

  • redirect to waitlist

ℹ️ For local or demo UITour use
To develop or test using Mozilla.UITour locally you need to create some custom preferences in about:config.

browser.uitour.testingOrigins (string) (value: local address e.g. http://127.0.0.1:8000)
browser.uitour.requireSecure (boolean) (value: false)

}
});
}
// TODO: Else ensure expected campaign is associated with download
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URLs like http://localhost:8000/en-US/smart-window/?utm_campaign=smart_window will automatically apply the UTM values to stub attribution parameters, but we probably can't rely on the URL 100% of the time

@maureenlholland
Copy link
Copy Markdown
Collaborator Author

maureenlholland commented Mar 16, 2026

TODO:

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.77%. Comparing base (2f685c4) to head (7cfecdc).
⚠️ Report is 86 commits behind head on main.

Files with missing lines Patch % Lines
springfield/firefox/views.py 40.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1151      +/-   ##
==========================================
- Coverage   77.81%   77.77%   -0.05%     
==========================================
  Files         131      131              
  Lines        8091     8103      +12     
==========================================
+ Hits         6296     6302       +6     
- Misses       1795     1801       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


### URL: https://www-dev.springfield.moz.works/smart-window/

# TODO Smart Window as brand variable? Include comment?
Copy link
Copy Markdown
Collaborator Author

@maureenlholland maureenlholland Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep forgetting if I can do this, I don't think so.

These files should be handled through Smartling. We cannot configure a subset of locales for special cases, all the vendor locales always go to Smartling

edit: as discussed here: #818 (comment)

@maureenlholland
Copy link
Copy Markdown
Collaborator Author

closing in favour of CMS version: #1247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant