Skip to content

Conversation

@camd
Copy link
Collaborator

@camd camd commented Jan 24, 2026

I split PR #9124 into 3 PRs because the set of changes was becoming too large and convoluted. So I will close that PR in lieu of these 3.

PR 1: camd/pr1-infrastructure-defaultprops

  • Upgrades packages and pnpm version
  • Fixes React defaultProps deprecation warnings
  • Fixes React console warnings for duplicate keys and null props
  • Infrastructure/tooling changes

PR 2: camd/pr2-test-coverage (based on PR 1)

  • Adds comprehensive unit tests for RSPack migration
  • Improves test coverage in key areas

PR 3: camd/pr3-job-selection-fix (based on PR 2)

  • Converts class components to functional (Push, PushHeader, PushJobs, etc.)
  • Fixes the job selection race condition
  • Adds Zustand migration notes documentation
  • Tests for useJobButtonRegistry / useDebounce

Branch Relationships

  master                                                                                                                                                                               
    └── camd/pr1-infrastructure-defaultprops                                                                                                                                           
          └── camd/pr2-test-coverage                                                                                                                                                   
                └── camd/pr3-job-selection-fix                                                                                                                                         

Merge Order

  1. Merge PR 1 first
  2. Rebase PR 2 on master, then merge
  3. Rebase PR 3 on master, then merge

@camd camd self-assigned this Jan 24, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2026

Codecov Report

❌ Patch coverage is 43.22034% with 134 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.82%. Comparing base (fac1470) to head (34cd1c5).

Files with missing lines Patch % Lines
ui/intermittent-failures/Layout.jsx 0.00% 10 Missing ⚠️
ui/shared/RevisionInformation.jsx 0.00% 9 Missing ⚠️
ui/job-view/details/summary/SummaryPanel.jsx 0.00% 7 Missing ⚠️
ui/intermittent-failures/BugDetailsView.jsx 0.00% 5 Missing ⚠️
ui/perfherder/alerts/AlertTable.jsx 44.44% 5 Missing ⚠️
ui/shared/FilterControls.jsx 0.00% 5 Missing ⚠️
ui/job-view/details/DetailsPanel.jsx 75.00% 4 Missing ⚠️
ui/perfherder/graphs/GraphsContainer.jsx 42.85% 4 Missing ⚠️
ui/infra-compare/InfraCompareTableControls.jsx 0.00% 3 Missing ⚠️
ui/intermittent-failures/MainView.jsx 0.00% 3 Missing ⚠️
... and 44 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9178      +/-   ##
==========================================
- Coverage   82.05%   81.82%   -0.24%     
==========================================
  Files         602      602              
  Lines       33794    33880      +86     
  Branches     3017     3206     +189     
==========================================
- Hits        27731    27722       -9     
- Misses       5938     6033      +95     
  Partials      125      125              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@camd camd force-pushed the camd/pr1-infrastructure-defaultprops branch from dfa1c11 to bc45776 Compare January 24, 2026 19:20
- Update pnpm version
- Optimize tests and docker configuration
- Add markdown formatting scripts and fix lint errors
- Upgrade packages
- Fix deprecations with defaultProps
- Fix React console warnings for duplicate keys and null props

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@camd camd force-pushed the camd/pr1-infrastructure-defaultprops branch from bc45776 to 34cd1c5 Compare January 24, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants