[gecko] Support AutoTArrays created from rust.#70
Merged
nicoburns merged 1 commit intomozilla:mainfrom Aug 19, 2025
emilio:auto-thin-vec
Merged
[gecko] Support AutoTArrays created from rust.#70nicoburns merged 1 commit intomozilla:mainfrom emilio:auto-thin-vec
nicoburns merged 1 commit intomozilla:mainfrom
emilio:auto-thin-vec
Conversation
This is a patch to add basic support to rust-created AutoTArrays. The existing AutoTArray handling was slightly broken, as thin-vec had a subtly different interpretation of the mIsAutoArray member than Gecko. You can read the details in the commit messages of https://bugzilla.mozilla.org/show_bug.cgi?id=1983704, but the TLDR is that I made Gecko match the thin-vec interpretation. No behavior change outside of the gecko-ffi mode. I'm adding some extra tests in that bug. Reviewed upstream by Nika. See also: https://bugzil.la/1978229 Differential Revision: https://phabricator.services.mozilla.com/D257930
nicoburns
approved these changes
Aug 19, 2025
Collaborator
nicoburns
left a comment
nicoburns
left a comment
There was a problem hiding this comment.
I am unable to give this a meaningful review, but I am happy to rubber stamp it on the basis that it has been reviewed within Mozilla (review is linked).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a patch to add basic support to rust-created AutoTArrays. The existing AutoTArray handling was slightly broken, as thin-vec had a subtly different interpretation of the mIsAutoArray member than Gecko.
You can read the details in the commit messages of https://bugzilla.mozilla.org/show_bug.cgi?id=1983704, but the TLDR is that I made Gecko match the thin-vec interpretation.
No behavior change outside of the gecko-ffi mode. I'm adding some extra tests in that bug.
Reviewed upstream by Nika.
See also: https://bugzil.la/1978229
Differential Revision: https://phabricator.services.mozilla.com/D257930