Make NativeDate.toLocaleString() behave more like real browsers#2338
Merged
gbrail merged 1 commit intomozilla:masterfrom Mar 21, 2026
Merged
Make NativeDate.toLocaleString() behave more like real browsers#2338gbrail merged 1 commit intomozilla:masterfrom
gbrail merged 1 commit intomozilla:masterfrom
Conversation
Co-authored-by: Lai Quang Duong
Collaborator
|
This looks good to me, and works, although I don't know if it will conflict with one of the upcoming PRs to convert descriptors - at some point we'll want to move Date away from IdFunctionObject. But it looks good to me, thanks! |
Contributor
|
Rebasing that should be pretty easy, happy to see this go in. Edit: wait, Date is already moved to descriptors. |
Collaborator
Author
|
@aardvark179 yes its already descriptor based |
Collaborator
|
No worries, I was confused because in the PR I saw a switch statement, but I now see that's called in a helper function. I'll do this soon. |
Collaborator
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Lai Quang Duong
This PR does the following
Make toLocaleString(), toLocaleDateString(), and toLocaleTimeString() output closer to real browser behavior by building DateTimeFormatter dynamically using the resolved locale instead of static pre-built formatters.
Now the outputs are almost identical to real browser with the exception of some minor cases.
see HtmlUnit#20