Simplify serialisation of NativeJavaObject and JavaMembers#2249
Simplify serialisation of NativeJavaObject and JavaMembers#2249aardvark179 wants to merge 6 commits intomozilla:masterfrom
NativeJavaObject and JavaMembers#2249Conversation
|
A bit amazed by the fact that this PR didn't cause any additional error. I was expecting some |
|
Good point. I'll make that one serialisable too, and add some more to the tests. |
|
I think serializing each NativeJavaXXX object separately is a bad idea, especially considering the raw member objects ( Actually I think nothing in JavaMembers should be serializable at all, other than the name of the class that this JavaMembers reflects |
|
We have to serialise those things, they can become reachable via multiple routes by assigning them to other variables. I'd be happy to see a rewrite of JavaMembers that separates the raw members out and never serialises those, but then you'll have to make sure all the |
2d199e5 to
44c3cd2
Compare
44c3cd2 to
f3212e3
Compare
This fixes #2248. It turned out to be much simpler to fix than I had feared as almost everything was already serialisable.