Bug-1915777: Make test tags theme aware #993
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the TestHeader and SubtestsRevisionHeader by making tag options aware of light. The changes made are: * Import theme hook in both TestHeader and SubtestsRevisionHeader * Update `styles` object in both TestHeader and SubtestsRevisionHeader to choose background color of span based on theme * Update color of tag based on theme * Add new colors to `styles/Colors.ts`
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #993 +/- ##
==========================================
- Coverage 96.38% 96.01% -0.37%
==========================================
Files 104 104
Lines 3016 3040 +24
Branches 686 706 +20
==========================================
+ Hits 2907 2919 +12
- Misses 108 114 +6
- Partials 1 7 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
Converting this to draft. I will have a look at improving the tests |
Author
|
@kala-moz Since this is a change to an UI element color, do we have to write tests for it ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the tag options used in the
TestHeaderandSubtestsRevisionHeaderto change the tag background and font based on the theme chosen (dark / light). New background colors are defined in thestyles/Colors.tsfor the option and existing font colors are reused for the font.This has been tested locally and the screenshots are as below.
npm run fix-allhas been applied before creating the commit.@davehunt @kala-moz