add new accounts db count table. remove old one#1116
Merged
Conversation
sean-rose
reviewed
Dec 5, 2024
Comment on lines
+620
to
+623
| measures: | ||
| count_sum: | ||
| type: sum | ||
| sql: ${count} |
Contributor
There was a problem hiding this comment.
This is kind of an unrelated change, but we'll allow it. 😉
Co-authored-by: Sean Rose <1994030+sean-rose@users.noreply.github.com>
Co-authored-by: Sean Rose <1994030+sean-rose@users.noreply.github.com>
Co-authored-by: Sean Rose <1994030+sean-rose@users.noreply.github.com>
Co-authored-by: Sean Rose <1994030+sean-rose@users.noreply.github.com>
sean-rose
approved these changes
Dec 6, 2024
Contributor
sean-rose
left a comment
sean-rose
left a comment
There was a problem hiding this comment.
The moz-fx-data-shared-prod.accounts_backend.monitoring_db_counts view added in mozilla/bigquery-etl#6599 has been deployed, so this is good to go.
Member
Author
|
Thanks. I don't have write-access to this repository fwiw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See related new table @ mozilla/bigquery-etl#6511 . /cc @akkomar @sean-rose