Conversation
moibra05
requested review from
freshstrangemusic,
jaredlockhart and
yashikakhurana
as code owners
Contributor
Author
|
jaredlockhart
requested changes
Feb 3, 2026
Collaborator
jaredlockhart
left a comment
jaredlockhart
left a comment
There was a problem hiding this comment.
Very nice and clean, but one note is if we're introducing that additional context into the view then we should update the view test to check that it's there 🙏
jaredlockhart
approved these changes
Feb 3, 2026
Collaborator
jaredlockhart
left a comment
jaredlockhart
left a comment
There was a problem hiding this comment.
Yep very nice g/j 🎉
Comment on lines
+3516
to
+3521
| outcome_1 = Outcomes.get_by_slug_and_application("desktop_outcome_1", application) | ||
| outcome_2 = Outcomes.get_by_slug_and_application("desktop_outcome_2", application) | ||
| experiment = NimbusExperimentFactory.create( | ||
| application=application, | ||
| primary_outcomes=[outcome_1.slug], | ||
| secondary_outcomes=[outcome_2.slug], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
Fixes #14520