This repository was archived by the owner on Jan 31, 2018. It is now read-only.
[#3200] Deselect track events on click, not mouseodwn to allow blur even... #1649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vents to happen first.
… way, events like blur that don't fire while not in the dom can still work as they are now, still in the dom.
Contributor
There was a problem hiding this comment.
Correct me if I'm wrong, but I'm pretty sure parentElement is always:
<div class="butter-editor-content" >
...
</div>If I'm right, I'm wondering why it needs to be something passed along the entire way through. Can't it just be a hard coded value? Or is this somehow too risky/rigid of a design?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ts to happen first.