Skip to content

test: unpin hypothesis and bump version#3606

Draft
ahal wants to merge 1 commit intomozilla-releng:mainfrom
ahal:ahal/push-utxxklpzvtpn
Draft

test: unpin hypothesis and bump version#3606
ahal wants to merge 1 commit intomozilla-releng:mainfrom
ahal:ahal/push-utxxklpzvtpn

Conversation

@ahal
Copy link
Contributor

@ahal ahal commented Jan 12, 2026

No description provided.

@ahal ahal self-assigned this Jan 12, 2026
@ahal
Copy link
Contributor Author

ahal commented Jan 12, 2026

The issue that forced the pin was fixed in:
HypothesisWorks/hypothesis#4639

However, the maintainers pointed out that we're setting things up poorly:

Thanks Andrew. To clarify, the issue was the json strategy passes lambda x: useful_list | useful_dict as the extension strategy to st.recursive, but this doesn't actually use x and therefore doesn't recurse more than one level.

We started assuming this in the new min_leaves feature, and have now both relaxed this assumption so this code works again, and added a warning when we detect this class of miss-stated extend.

I recommend adjusting this strategy to recurse on x regardless, as its test distribution is probably weaker than expected at the moment!

I'll attempt to also fix up the test.

@jcristau
Copy link
Contributor

jcristau commented Feb 5, 2026

@ahal worth getting this landed, and file a bug/issue to fix the test as a followup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants