Bug 2036191 - Crash Signature Field Mismatch in Bugzilla REST API#2612
Open
dklawren wants to merge 2 commits into
Open
Bug 2036191 - Crash Signature Field Mismatch in Bugzilla REST API#2612dklawren wants to merge 2 commits into
dklawren wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a Bugzilla REST API inconsistency where cf_crash_signature (and other custom fields) may be stored on a bug but omitted from REST responses due to product/component visibility filtering.
Changes:
- Add “Web Compatibility” to the product allowlist for
cf_crash_signaturevisibility. - Update REST bug serialization to also emit non-empty values for custom fields that are not enabled for the bug’s product/component.
- Update bug update logic (
set_all) to only set custom fields that are enabled for the bug’s current product/component.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| extensions/BMO/lib/Data.pm | Expands cf_crash_signature visibility to include the “Web Compatibility” product. |
| Bugzilla/WebService/Bug.pm | REST: emits stored values for non-enabled custom fields when non-empty. |
| Bugzilla/Bug.pm | Limits which custom fields set_all will set based on product/component-enabled custom fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.