Added an urllib encoding to the raw url before the get request to the…#5
Open
hendrik-pfaffendorf-navcomm wants to merge 1 commit intomovomx:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… server
During usage of this library I encountered the problem that the library doesn't encode the URL before submitting the GET request to the server.
In particular I stumbled into issues where a hashtag character was plainly placed within the URL and I got an error message from the server because of it. By first encoding the URL with the urllib quote_plus function, the hashtag got encoded properly and the library works as expected.