modernize cmake#1
Draft
ClausKlein wants to merge 15 commits into
Draft
Conversation
prevent clang-tidy warnings use thread sanitizer as default while tests test the install config package too
add macos build host too
try again with windows, but MVC compiler!
ClausKlein
commented
Mar 8, 2022
| requires std::is_copy_constructible_v<T>; | ||
| { g1 < g2 } -> std::convertible_to<bool>; | ||
| { g1 == g2 } -> std::convertible_to<bool>; | ||
| { g1 < g2 } -> std::same_as<bool>; |
Author
There was a problem hiding this comment.
Note: this does not compile with Apple clang version 13.0.0
ClausKlein
commented
Mar 8, 2022
|
|
||
| sig.connect(printer("Second"), 1); | ||
| sig.connect(printer("Last"), std::numeric_limits<sigslot::group_id>::max()); | ||
| //FIXME: sig.connect(printer("Last"), std::numeric_limits<sigslot::group_id>::max()); |
Author
There was a problem hiding this comment.
NOTE: this does not compile on OSX?
ClausKlein
commented
Mar 8, 2022
| void m1() { ti += 1; } | ||
| void m2() { ti += 1; } | ||
| void m3() { ti += 1; } | ||
| void m1() const { ti += i; } |
Author
There was a problem hiding this comment.
only to prevent clang-tidy warning about convert to static function
ClausKlein
commented
Mar 8, 2022
|
|
||
| struct s { | ||
| void m() { std::cout << "member function\n"; } | ||
| void m() const { std::cout << "member function: v=" << v << std::endl; } |
Author
There was a problem hiding this comment.
only to prevent clang-tidy warning about convert to static function
ClausKlein
commented
Mar 8, 2022
| -Wno-gnu-zero-variadic-macro-arguments;-Wno-documentation;-Wno-missing-prototypes; | ||
| -Wno-padded;-Wno-weak-vtables;-Wno-c++17-extensions;-Wno-shadow-field-in-constructor; | ||
| -Wno-return-std-move-in-c++11> | ||
| $<$<BOOL:${SIGSLOT_COMPILER_CLANG_OR_CLANGCL_OR_GCC}>:-Wpedantic> |
Author
There was a problem hiding this comment.
that seems better to me, and many of this -Wno-warnings are not known by Apple clang compiler!
ClausKlein
commented
Mar 8, 2022
| option(SIGSLOT_COMPILE_EXAMPLES "Compile optional exemples" ON) | ||
| option(SIGSLOT_COMPILE_TESTS "Compile tests" ON) | ||
| option(SIGSLOT_RUN_TESTS "Compile and run tests" ON) | ||
| option(SIGSLOT_RUN_TESTS "Compile and run tests" OFF) |
Author
There was a problem hiding this comment.
That is not intuitive to me! With EXCLUDE_FROM_ALL, the tests are not compiled?
test with thread sanitizer again
add TODO notes
some are suppressed only with NOLINT!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prevent clang-tidy warnings
use thread sanitizer as default while tests
test the install config package too