Resolve stack overflow in SortedSet.reduce and reduceRight#244
Open
alex-dunn wants to merge 1 commit into
Open
Resolve stack overflow in SortedSet.reduce and reduceRight#244alex-dunn wants to merge 1 commit into
alex-dunn wants to merge 1 commit into
Conversation
Replace implementations of SortedSet.reduce and reduceRight. Current implementations are recursive and so will inevitably hit a stack overflow exception at some point. New implementations use the Iterator to traverse the tree.
Contributor
|
Possible duplicate 85f00f8 |
Contributor
|
Fix confirmed on master via this comment #241 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #150, Resolve stack overflow for SortedSet reduce & reduceRight
Replace recursive implementation with version that uses the Iterator. The limit in size of the set now seems to be whenever the browser runs out of memory to allocate for the main tree + the history tree in splay.
Updated the Iterator to take a 4th argument:
reverse. Ifreverseis falsey then behaviour is the same as master, otherwise it will iterator through the set in the reverse order.