Conversation
This is a proposal for a new interface for property change observers, intended to subvert property change listeners.
This change makes it possible for a deprecated shim of the old property change listener system to coexist using the new property change observer system.
Retain last seen value, precompute dispatch method.
- Allow a thunk to be shared by instances if the prototype is made
observable.
- Fix a bug where observers on multiple properties of the same object
would interfere.
- Test coverage for the working edge case of an object with a setter
but no getter.
This adds support for map, range, and array observers, with a design coherent with the new property observers.
Such that all specs pass.
Based in changes to the iterator specification slated for ECMAScript 6, but extended to pass indicies through on iteration objects. This reimplementation largely avoids using closures for iterator instances. Methods of iterators that return new iterators are now conjugated differently, to avoid colliding with the variant that will produce a plain array. For example, `zipIterator` is now `iterateZip`. I have removed the type checks for callbacks. Any object implementing `call` will suffice. :warning: This commit introduces backward incompatible changes and should await a major version.
Also, factor this facility out of `filter`, so that recounting is an orthogonal concern. Recounting enforces sequential indexes on a wrapped iterator.
hthetiot
changed the title
Contributor
Author
|
|
kriskowal
reviewed
Dec 7, 2017
Member
kriskowal
left a comment
kriskowal
left a comment
There was a problem hiding this comment.
Hey, this is a big effort. Are we attempted to reconcile v1 and v2 branches? Is there concurrent work on Montage and FRB to use the v2 observers?
| structures with idiomatic iterfaces, including extensions for Array and | ||
| Object. | ||
|
|
||
| <<<<<<< HEAD |
Contributor
Author
There was a problem hiding this comment.
Yes I will fix conflict in README.
Contributor
Author
|
This was referenced Apr 15, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.