Open
Conversation
This dimension is used by Noah-MP only, and it sets the maximum number of snowpack layers in the model.
Author
|
@aomanzi has tested these changes and the code seems to be processing the snow-level dependent variables as intended, so I am updating the status to ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor edit, to allow convert_mpas to process variables with multiple snow levels. The new dimension
nSnowLevelsis used by Noah-MP only.The edits are fairly straightforward, but this requires some testing first, thus I am flagging it as draft for the time being. I will set it as "ready for review" once the tests are successful.