memfs: Document MemFile write/close/sync semantics#10
Merged
Conversation
MemFile buffers writes locally and only publishes them on Close, while osfs makes writes visible immediately. Sync is a no-op on memfs and in particular does NOT publish buffered bytes. These differences can trip up callers porting code between backends, so spell them out on the MemFile type doc and on each of Write, Close, and Sync.
mojatter
added a commit
that referenced
this pull request
Apr 7, 2026
The original v0.5.0 entry attributed PRs #6-#10 (Rename/Sync, lint CI, memfs Sub fix, store perf, memfs docs) to v0.5.0, but those were already shipped in v0.4.1. Rewrite the entry to reflect what is actually new since v0.4.1: README additions, CHANGELOG itself, the Go matrix and -race CI, the Go 1.24 minimum, and the NewOSFS deprecation timeline.
2 tasks
mojatter
added a commit
that referenced
this pull request
Apr 7, 2026
The original v0.5.0 entry attributed PRs #6-#10 (Rename/Sync, lint CI, memfs Sub fix, store perf, memfs docs) to v0.5.0, but those were already shipped in v0.4.1. Rewrite the entry to reflect what is actually new since v0.4.1: README additions, CHANGELOG itself, the Go matrix and -race CI, the Go 1.24 minimum, and the NewOSFS deprecation timeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MemFile buffers writes locally and only publishes them on Close, while osfs makes writes visible immediately. Sync is a no-op on memfs and in particular does NOT publish buffered bytes. These differences can trip up callers porting code between backends, so spell them out on the MemFile type doc and on each of Write, Close, and Sync.