docs(releasing): Document the two-PR flow for cmd/s2-server#132
Merged
Conversation
The single-PR instruction would break e2e: cmd/s2-server has no replace directives, so its GOWORK=off build cannot resolve the not-yet-published version. Tag the five replace-modules first, then bump and tag cmd/s2-server separately - matching what v0.11.0/v0.11.1 actually did.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release guide described a single PR that bumps every submodule — including
cmd/s2-server— and tags all seven modules at once. That does not work:cmd/s2-serverhas noreplacedirectives, so itsGOWORK=offbuild (the e2e image viaserver/Dockerfile, and the GoReleaser binary) resolves intra-repo deps fromproxy.golang.organd cannot fetch a version whose tag does not exist yet. Both v0.11.0 (#119 → #120) and v0.11.1 (#130 → #131) actually used a two-PR flow.This rewrites the flow to match reality:
replacedirectives;cmd/s2-serveris explicitly excluded.cmd/s2-server/go.mod, e.g.golang.org/x/net), and when to reorder.cmd/s2-serverin a follow-up PR once the tags are published, then tagscmd/s2-server/v*.