Feature/core contracts#2
Merged
Merged
Conversation
mohdaquib
commented
May 5, 2026
mohdaquib
commented
Owner
- Implemented core contracts model classes
- Added `A11yNode` data class to represent a node in the accessibility tree - Implemented lightweight `Color`, `DpSize`, and `Rect` models to mirror Compose/Android APIs without external dependencies - Established basic geometric and visual properties for accessibility scanning (bounds, touch targets, text color)
- Created `A11ySeverity` sealed interface with `Error`, `Warning`, and `Info` levels - Implemented `Comparable` interface based on a defined `sortOrder` for each level
- Created `A11ySeverity` sealed interface with `Error`, `Warning`, and `Info` levels - Implemented `Comparable` interface based on a defined `sortOrder` for each level
- Added `A11yRule` interface to define the standard structure for accessibility checks - Implemented `BaseA11yRule` abstract class to provide common functionality for rule evaluation and issue creation - Established a consistent pattern for generating `A11yIssue` objects with rule-level metadata
- Implemented `ScanResult` data class to encapsulate accessibility scan data - Added computed properties for issue counts by severity and overall scan score - Included basic scan metadata such as timestamp, node count, and rule pass/fail statistics
- Added `ScannerState` sealed interface to represent the lifecycle of a scan (Idle, Scanning, Complete, Error) - Added `ScannerConfig` data class to manage accessibility rule thresholds and settings
- Added launcher icons and adaptive icon XMLs for the sample module
- Updated Detekt configuration:
- Disabled `NewLineAtEndOfFile` and `FinalNewline` rules
- Enabled `ForbiddenComment` rule for TODO, FIXME, and STOPSHIP
- Relaxed `FunctionNaming` pattern to allow uppercase starting letters (supporting Composable functions)
- Added `detekt-formatting` plugin to the root build configuration - Updated `detekt.yml` to use the correct `comments` property for `ForbiddenComment` - Corrected the group ID for `androidx-compose-bom` in the version catalog - Added launcher icon resources for the sample module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.