MOEN-44410: Added support for epoch time attribute#99
Open
RakshithaAcharya wants to merge 1 commit into
Open
Conversation
|
🚪 Hodor is reviewing this PR... 👀 |
moe-hodor
Bot
added
branch:feature
![moe-hodor[bot]](https://avatars.githubusercontent.com/in/3251438?s=60&v=4){kind=small}
| case MoEngagePluginConstants.UserAttribute.timestamp: | ||
| if let timeStamp = userAttribute.value as? String { | ||
| MoEngageSDKAnalytics.sharedInstance.setUserAttributeISODate(timeStamp, withAttributeName: userAttribute.name, forAppID: identifier) | ||
| } else if let timeStamp = userAttribute.value as? Double { |
There was a problem hiding this comment.
userAttribute.value is neither String (line 127) nor Double (line 128), the timestamp attribute is silently ignored with no logging or error. This happens when a plugin sends an Int, Float, NSNumber, or any other type for a timestamp attribute.
Impact: Plugin developers won't know their timestamp wasn't tracked. The general attribute handler (lines 116-123) has the same issue, so this is a pre-existing pattern in this codebase.
Suggestion: Consider adding an else clause after line 129:
} else {
MoEngageLogger.logDefault(logLevel: .error, message: "Invalid timestamp value type for attribute '\(userAttribute.name)': expected String (ISO) or Double (epoch), got \(type(of: userAttribute.value))")
}This helps plugin SDK authors debug integration issues. Not a blocker — log the warning in a follow-up ticket if desired.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Ticket
Description