Fixes thread_auto_close execution when disabled. #3423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue #3290 which caused threads to be auto-closed even if `thread_auto_close` has been disabled. There was also an issue that closed the thread when the user has responded to mods. The thread should stay open and only auto close when the staff has replied back.
StephenDaDev
requested review from
a team,
StephenDaDev,
lorenzo132 and
sebkuip
and removed request for
StephenDaDev,
lorenzo132 and
sebkuip
Member
|
Not sure why it merged them (the review requests) when I did that |
This solves the thread from autoclosing if the closure has been cancelled earlier in a thread.
lorenzo132
previously approved these changes
Dec 20, 2025
sebkuip
requested changes
Dec 20, 2025
Member
sebkuip
left a comment
sebkuip
left a comment
There was a problem hiding this comment.
There's some extra mongo calls that I think could be removed to save bandwidth limits. Otherwise seems okay
I had added a small bugfix aswell for pagination when an invalid config var was given. This happened to occur upon removing the `thread_auto_close` config.
lorenzo132
approved these changes
Dec 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue #3290 which caused threads to be auto-closed even if
thread_auto_closehas been disabled.There was also an issue that closed the thread when the user has responded to mods. The thread should stay open and only auto close when the staff has replied back.