Skip to content

Prune trailing spaces; replace tabs with spaces#2128

Open
Tc-Fast wants to merge 2 commits intomodelica:mainfrom
Tc-Fast:white_space
Open

Prune trailing spaces; replace tabs with spaces#2128
Tc-Fast wants to merge 2 commits intomodelica:mainfrom
Tc-Fast:white_space

Conversation

@Tc-Fast
Copy link
Copy Markdown
Contributor

@Tc-Fast Tc-Fast commented Feb 20, 2026

No description provided.

@chrbertsch
Copy link
Copy Markdown
Collaborator

@Tc-Fast : What is the benefit of replacing tabs with spaces? Do or should we have a formatting rule in https://github.com/modelica/fmi-standard/blob/main/CONTRIBUTING.md?

@Tc-Fast
Copy link
Copy Markdown
Contributor Author

Tc-Fast commented Feb 24, 2026

Modern coding conventions suggest to use only spaces and no tabs.

@chrbertsch
Copy link
Copy Markdown
Collaborator

chrbertsch commented Feb 24, 2026

Torsten: We should an CI action and have guidance how to avoid this happening again.
Pierre: one normally uses pre-commit-hooks, one could have an automated Github check
Torsten: sometimes they destroy formatting
Klaus: I would not use pre-commit-hooks ... have bad experience ...
Pierre: merge this only once we have somthing in place to prevent it in the future
Torsten: i will look into this.

@chrbertsch chrbertsch self-requested a review February 24, 2026 15:16
@chrbertsch
Copy link
Copy Markdown
Collaborator

Torsten: We could include a simple Python script in the CI Pipeline

@chrbertsch chrbertsch assigned t-sommer and unassigned t-sommer Apr 7, 2026
@Tc-Fast
Copy link
Copy Markdown
Contributor Author

Tc-Fast commented Apr 14, 2026

Added a check for trailing spaces. This check currently excludes all *.svg files, since they are generated/exported by some tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants