Fix connecting via Host Key#1
Conversation
|
Backward compatibility issue with This breaks compatibility when the client and server are running different versions. If an updated client connects to an older server (or vice versa), the parser fails with Additionally, Suggested fix: Make |
connectRemote returned a host slice pointing into a stack-local buffer. Once the function returned, the slice became a dangling pointer. Dupe the host onto the heap so it outlives the call.
|
Down to fix with the suggestion if backwards compatibility is an issue. Considering This isn't yet version 1.0 I didn't put a thought to that. |
Previously if we passed a ssh host key, e.g.
zmosh attach -r foo devwhere the ssh config file looked like
It would fail to connect due to trying to connect to foo after the ssh bootstrap