fix(protocol): require session close before branch merge#16
Merged
mmilanez merged 2 commits intoJun 2, 2026
Merged
Conversation
…oses mmilanez#2) Adds a branch ordering rule to the protocol: all session-close artifacts must be committed on the feature branch before the PR is opened, not written to the default branch after merge. Changes: - PROTOCOL_RULES.md §P3: new "Branch ordering rule" subsection + one checklist item in the handoff schema (v2.0.0 → v2.0.1) - modules/git-substrate.md: new §M-git-6 with git-specific enforcement and reviewer signal (v1.1.0 → v1.2.0) - README.md: version history entry for 2.0.4 (per §M-git-3) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
|
Thanks for opening the clean replacement PR. The diff now looks focused and reviewable. Before final review/merge, please handle two small PR-maintenance items on your side:
After those two updates and passing CI, this should be ready for final review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2.
Adds an explicit branch ordering rule to the protocol: all session-close artifacts must be committed on the feature branch before the PR is opened, not written to the default branch after merge.
Changes
.agents/PROTOCOL_RULES.md— kernel v2.0.0 → v2.0.1### Branch ordering rule (v2.0.1+)subsection in §P3, before the verification step- [ ] Session-close state written on the feature branch before the PR is opened (when substrate uses pull requests — see §M-git-6).agents/modules/git-substrate.md— v1.1.0 → v1.2.0§M-git-6 — Session close ordering before PR mergeafter existing §M-git-5README.md— version history entry for 2.0.4 (per §M-git-3)No
template/files. Single focused commit on a clean branch from currentmain. Replaces #15.Test plan
PROTOCOL_RULES.mdshowsVersion: 2.0.1git-substrate.mdshowsVersion: 1.2.0with §M-git-6 present2.0.4as the first version history entryContributed by @leadsolutions-mike as external collaborator.